Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dnd5e): 修正rc代骰,以及死亡豁免文案等问题 #918

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

fy0
Copy link
Member

@fy0 fy0 commented Jul 16, 2024

Fix #894

Fix #900

Fix #917

Fix #920

Close #893

修正死亡豁免表达式显示
修正seal.format对于dnd5e模板计算属性的错误显示
修正rc代骰问题
增加被察到模板

@fy0 fy0 changed the title fix[dnd5e]: 修正rc代骰,以及死亡豁免文案等问题 fix(dnd5e): 修正rc代骰,以及死亡豁免文案等问题 Jul 16, 2024
dice/ext_fun.go Outdated Show resolved Hide resolved
dice/ext_dnd5e.go Outdated Show resolved Hide resolved
dice/ext_dnd5e.go Outdated Show resolved Hide resolved
@Xiangze-Li
Copy link
Member

#920 是否也由此 PR 的修改解决?需要分析原问题 @fy0

@fy0
Copy link
Member Author

fy0 commented Jul 17, 2024

#920 是否也由此 PR 的修改解决?需要分析原问题 @fy0

理论能够解决,底层原因是getCtxProxyFirst中对ctx进行复制时带入了旧的vm

Copy link
Member

@Xiangze-Li Xiangze-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看求不懂,反正效果差不多

@Xiangze-Li Xiangze-Li merged commit a8ea76d into master Jul 18, 2024
3 checks passed
@Xiangze-Li Xiangze-Li deleted the fix/dnd5e-v150-issues-v3 branch July 18, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants