Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pickle with dill #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Replace pickle with dill #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Replace pickle with dill to address issue #327.
  • Loading branch information
@T0217
T0217 committed Aug 5, 2024
commit f18da1a7d30cd70870246d8f8299fb8e93770607
1 change: 1 addition & 0 deletions latest_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ sdv==1.15.0
tabulate==0.8.10
torch==2.3.1
tqdm==4.66.4
dill==0.3.8
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ dependencies = [
'rdt>=1.12.1',
'sdmetrics>=0.14.1',
'sdv>=1.13.1',
'dill>=0.3.8',
]

[project.urls]
Expand Down
4 changes: 2 additions & 2 deletions sdgym/benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import logging
import multiprocessing
import os
import pickle
import dill
import tracemalloc
import warnings
from datetime import datetime
Expand Down Expand Up @@ -157,7 +157,7 @@ def _synthesize(synthesizer_dict, real_data, metadata):
tracemalloc.start()
now = datetime.utcnow()
synthesizer_obj = get_synthesizer(data, metadata)
synthesizer_size = len(pickle.dumps(synthesizer_obj)) / N_BYTES_IN_MB
synthesizer_size = len(dill.dumps(synthesizer_obj)) / N_BYTES_IN_MB
train_now = datetime.utcnow()
synthetic_data = sample_from_synthesizer(synthesizer_obj, num_samples)
sample_now = datetime.utcnow()
Expand Down