New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[authorname] allow for non-0 #723

Merged

sds merged 1 commit into sds:master from drewrothstein:drew/authorname

Jul 14, 2020

Contributor

drewrothstein commented Jul 14, 2020

Updates the AuthorName check to be a little more inclusive by not requiring a first and last name.
Could also leave this as-is and have a 2-strings type of check (maybe called AuthorNameTwoStrings) or something to represent this default setting? Happy to do that if preferred.


          [authorname] allow for non-0

62baf5e

sds approved these changes

View reviewed changes

Owner

sds left a comment

Thank you! There wasn't much thought given when we originally added this hook, so this seems like a better default.

sds merged commit 2a7e266 into sds:master

sds added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels