Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ae04a9 ae681f ae5f50 #273

Merged
merged 7 commits into from
Jul 16, 2023
Merged

ae04a9 ae681f ae5f50 #273

merged 7 commits into from
Jul 16, 2023

Conversation

dziban303
Copy link
Collaborator

@dziban303 dziban303 commented Jul 13, 2023

Describe your changes

Added ae04a9 and ae681f, with images, and AE5F50, without. AE681F is a P-8 tactical hex but was most recently used by 169567—this aircraft also uses AE5F50, as it did ten hours ago. Which hex the photos should go into is sort of a dilemma, but I opted to put them into the hex it was most recently using.

Would like @Phaeton 's take on the image question. Should I add the same images to both hexes maybe? Or neither? Or the other one? Ugh

AE04A9 is an Army Citation.


Final content

  • ae681f = tactical code, no pics
  • ae5f50 = 169567, with pics
  • ae04a9 = army c560, with pics
  • ae68b3 = usaf wolfhound, with pics

Checklist before requesting a review

  • I have performed a self-review of my code.
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers.

@github-actions github-actions bot added images Plane images planes Plane info labels Jul 13, 2023
@Phaeton
Copy link
Collaborator

Phaeton commented Jul 14, 2023

@dziban303 I would put the image on AE5F50

@dziban303
Copy link
Collaborator Author

@Phaeton done

@Phaeton
Copy link
Collaborator

Phaeton commented Jul 14, 2023

Question, should AE5F50 have the reg as 169567 vs tactical?

@dziban303
Copy link
Collaborator Author

@Phaeton done. also added pics for 🐺🐶 ae68b3. I'm done with this PR

Copy link
Collaborator

@Phaeton Phaeton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo on AE04A9's Type

plane-alert-db.csv Show resolved Hide resolved
@dziban303
Copy link
Collaborator Author

Weird. Not sure how I managed to do that.

@dziban303 dziban303 merged commit 2f3e529 into sdr-enthusiasts:main Jul 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
images Plane images planes Plane info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants