Sync plane_images.txt with *.csv database files #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Phaeton I made some small changes to your script to prevent duplicate reading of the databases. Please check if the code still does what you had in mind. If you think it is okay, we can merge it 👍🏻. |
rickstaa
approved these changes
Apr 13, 2023
|
@rickstaa Looks good to me. I tweaked the dataframe naming slightly to align with the existing logic. No changes to function. |
Great, thanks again for implementing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add additional action to
create_db_derivatives.pyto add missing ICAO hexes to theplane_images.txtfile. This will resolve #199.Checklist before requesting a review