Correct ACE463 Photos

[Phaeton]

Describe your changes

Correct ACE463 Photos that are currently incorrect

Checklist before requesting a review

• I have performed a self-review of my code.
• While waiting for someone to review your request, please help review another open pull request to support the maintainers.

[github-actions]

Please only suggest/make any changes to the following files:

• plane-alert-db.csv: This is the main database file. All non-image changes should be done here.
• plane-alert-pia.csv: This list contains PIA planes.
• plane-alert-twitter-blocked.csv: This source file contains planes that will cause your Twitter account to be banned. Please use it with care.
• plane-alert-ukraine.csv: This list contains Ukrainian planes.
• plane_images.txt: You can add plane images in this source file.

All other files are generated from this file using the .github/workflows/create_db_derivatives.yaml GitHub action, and if you do not make your changes there, they will be overwritten and lost.

[Phaeton]

@rickstaa It looks like this pull request was incorrectly tagged with the planes label. Only images were updated.

[Phaeton]

@rickstaa I see why. As the derivative files were also updated, *.csv files, it got the second tag.

[dziban303]

Well I can't find where to add an approval tag but it looks good to me

[Phaeton]

well, it seems if you add additional commits to an existing pull request, the invalid label is applied?

[dziban303]

I found the approve thing 🎉

[dziban303]

well, it seems if you add additional commits to an existing pull request, the invalid label is applied?

So is the 'correct' way of doing this to create a new branch in our own forks and merge those individually? I'm just used to committing everything to the main branch. I have no idea how to do a different fork in VSCode 😩

[rickstaa]

well, it seems if you add additional commits to an existing pull request, the invalid label is applied?

So is the 'correct' way of doing this to create a new branch in our own forks and merge those individually? I'm just used to committing everything to the main branch. I have no idea how to do a different fork in VSCode 😩

@dziban303 no, you and @Phaeton were using the correct way. The problems were caused by different line endings between Linux and Windows. I now changed the action 👍🏻.

[rickstaa]

Merged in #163.