Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hawkeye additions #161

Merged
merged 4 commits into from
Mar 17, 2023
Merged

hawkeye additions #161

merged 4 commits into from
Mar 17, 2023

Conversation

dziban303
Copy link
Collaborator

Describe your changes

  • Added four E-2 Hawkeyes.
  • Fixed tags for two other USN Hawkeyes already in the database, which were using the ASW tags rather than AWACS tags.
  • Created Wikipedia shortlink to E-2 article for use with these in the future.

Sources: these a/c traveled as a group from Point Mugu to Key West today using LBERTY5x callsigns, a callsign used previously for members of VAW-115, The Liberty Bells, a Navy squadron which flies E-2 Hawkeyes. Imagery from the past year was found on twitter of two of these aircraft, confirming their hexes and tailcodes. Photos of the other two could not be located, but others have confirmed they are indeed Hawkeyes.

I didn't see any indication that the photos I found were free to use so I am not including them in the photos database.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers.

@github-actions github-actions bot added the planes Plane info label Mar 16, 2023
@github-actions
Copy link

Please only suggest/make any changes to the following files:

All other files are generated from this file using the .github/workflows/create_db_derivatives.yaml GitHub action, and if you do not make your changes there, they will be overwritten and lost.

Copy link
Collaborator

@Phaeton Phaeton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes all look good to me. @dziban303 for 168275, possibly the following photo could work https://www.airfighters.com/photo_9999_291207.jpg
@rickstaa should an edit that adds new planes to plane-alert-db.csv also add the framework to add photos to plane_images.txt? I see the derivatives action hitting a few other files, but not that one.

@dziban303
Copy link
Collaborator Author

dziban303 commented Mar 16, 2023 via email

@github-actions github-actions bot added images Plane images invalid This doesn't seem right labels Mar 16, 2023
@dziban303
Copy link
Collaborator Author

Yeah, I saw that coming, lol. No idea what it's complaining about now. Should be good to go.

@github-actions github-actions bot removed the invalid This doesn't seem right label Mar 17, 2023
@rickstaa rickstaa merged commit d1dbff0 into sdr-enthusiasts:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
images Plane images planes Plane info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants