-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small suggestions #75
Conversation
While this may be redundant to links elsewhere, I always feel that the easier it make for people to interact, the likelier they are to contribute. Signed-off-by: Dirk Hohndel <[email protected]>
Again, not sure I can claim this is needed - but it's one of those significant game changers that people often overlook. All you do is edit this one file. At least to me, that's brilliant. Signed-off-by: Dirk Hohndel <[email protected]>
It seems useful to point out that outdoor antennas tend to give more joy. It seems useful to acknowledge that Pis are currently hard to get. Maybe even a link to rpilocator.com. I certainly wasn't aware that this existed before getting into this hobby. Signed-off-by: Dirk Hohndel <[email protected]>
Since the elevation finder already gives you the lat/long in sufficient precision, it seems to make more sense to start with that and avoid having people first hunt for their coordinates and then for their altitude, only to get their coordinates from that as well... Signed-off-by: Dirk Hohndel <[email protected]>
|
||
## A computer running Linux | ||
|
||
Capable of running Docker, with at least one free USB port. This can be a Raspberry Pi or an x86. | ||
Capable of running Docker, with at least one free USB port. This can be a Raspberry Pi (or similar single board computer (SBC), given frequent supply issues with the Pi) or an x86. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a link to rpilocator here? I wonder if naming compatible pi clones would be worth doing, and (down another rabbit hole) if linking to news that Pi supply issues should be improving in 2023 would be worth doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a link to rpilocator here?
I asked that same question in the commit message :)
I wonder if naming compatible pi clones would be worth doing,
I'm personally playing with a Libre Computer Le Potato right now :)
and (down another rabbit hole) if linking to news that Pi supply issues should be improving in 2023 would be worth doing.
I hear pretty strong comments from others that this may be wishful thinking... who knows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw the comment about using a clone in your PR, didn't read the commits itself. I'm just a rando though, giving my thoughts. My vote would be to link to Le Potato and rpilocator and ignore the news.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy with a "suggested hardware" list, with a link (non-sponsored) to the hardware in question, and perhaps a list of users in the discord that use that hardware, in case newcomers have questions. Thoughts?
I notice that this actually touches text also changed in one of the other PRs... happy to update after those were merged |
I just resolved the conflicts. |
I'll merge this, and if anyone wants to add a "recommended hardware" section, this can be done in another PR. |
These are just a few minor edits - mainly to get an idea of the granularity and detail that you are comfortable getting from contributors.
I actually bought a spare little RPi clone board just so I would have a clean system on which to experiment with the docker setup in order to be able to work on improving the guide without disrupting my working system :)
Please feel free to redirect, make suggestions, tell me where I'm doing things that you'd rather have me not do. I want this to be useful.