Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added InfluxDB page and removed some first-person language #71

Merged
merged 7 commits into from
Feb 21, 2023

Conversation

wandering-andy
Copy link
Contributor

Should close issue #59. Mostly just took info from main README and put it in one place. I also edited some pages to reduce first-person language.

Copy link
Member

@mikenye mikenye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution! The addition of the InfluxDB stuff is just fantastic.

If you're able to take a look at the review commends and change accordingly, I will merge this PR.

Thanks again.

feeder-containers/feeding-flightradar24.md Outdated Show resolved Hide resolved
feeder-containers/feeding-flightradar24.md Outdated Show resolved Hide resolved
feeder-containers/feeding-radarbox.md Outdated Show resolved Hide resolved
foundations/common-tasks-and-info.md Outdated Show resolved Hide resolved
@wandering-andy
Copy link
Contributor Author

Fixed those lines you requested along with some more I/We switches. equipment-needed.md still has a lot of your old language in it. It'll probably need a full re-write. I also think install-docker-compose.md is outdated as docker-install.sh installs docker compose directly now, not in a container?

@mikenye
Copy link
Member

mikenye commented Feb 20, 2023

Thanks!

equipment-needed.md still has a lot of your old language in it. It'll probably need a full re-write.
Yes it will.

I also think install-docker-compose.md is outdated as docker-install.sh installs docker compose directly now, not in a container?
This is also correct.

Were you going to update these as part of this PR? If so I'll hold off merging it. If not, no problems I can merge these and those other changes can be done separately by you or someone else.

@mikenye mikenye merged commit 4886553 into sdr-enthusiasts:main Feb 21, 2023
@mikenye
Copy link
Member

mikenye commented Feb 21, 2023

Awesome work, thanks so much @wandering-andy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants