Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: redirect directly to FlightAware user statistics page #24

Closed
klara31 opened this issue May 5, 2020 · 10 comments
Closed

Suggestion: redirect directly to FlightAware user statistics page #24

klara31 opened this issue May 5, 2020 · 10 comments
Assignees

Comments

@klara31
Copy link

klara31 commented May 5, 2020

When clicking on the FlightAware logo on the top left, you are redirected to the FlightAware home page. It's a lot easier when you are directly redirected to your personal statistics page. When running locally, I was using the following patch:

--- /usr/share/dump1090-fa/html/index.html	2019-08-01 10:33:43.000000000 +0200
+++ /usr/share/dump1090-fa/html/index.html	2019-08-13 22:47:39.299981896 +0200
@@ -48,7 +48,7 @@
 
 		<div id="header" class="infoHeading">
 			<div class="logoContainer">
-				<a href="https://flightaware.com/" target="_blank"><img src="images/fa_logo_color.png" alt="FlightAware" class="flightawareLogo" srcset="images/fa_logo_color.png 1x, images/[email protected] 2x, images/[email protected] 3x"></a>
+				<a href="https://flightaware.com/adsb/stats/user/xxxxxxxxxxxxx" target="_blank"><img src="images/fa_logo_color.png" alt="FlightAware" class="flightawareLogo" srcset="images/fa_logo_color.png 1x, images/[email protected] 2x, images/[email protected] 3x"></a>
 				<img src="images/pa-sa-logo.png" alt="PiAware SkyAware" class="adsbLogo piAwareLogo" srcset="images/pa-sa-logo.png 1x, images/[email protected] 2x, images/[email protected] 3x">
 				<img src="images/ff-sa-logo.png" alt="FlightFeeder SkyAware" class="adsbLogo flightfeederLogo" srcset="images/ff-sa-logo.png 1x, images/[email protected] 2x, images/[email protected] 3x" style="display: none;">
 			</div>

Is it possible to implement this, probably using an runtime environment variable on this image?

Another request: add BING api key to the runtime environment variables.

@mikenye mikenye self-assigned this May 5, 2020
mikenye added a commit that referenced this issue May 5, 2020
mikenye added a commit that referenced this issue May 5, 2020
mikenye added a commit that referenced this issue May 5, 2020
Implement suggestion in issue #24
@klara31
Copy link
Author

klara31 commented May 5, 2020

Awesome! Thanks :)

@mikenye
Copy link
Member

mikenye commented May 6, 2020

No worries! Did it work for you?

Also, I've been googling about using a Bing API key with piaware... Do you have any info on this or suggestions on how to implement?

@mikenye mikenye added the question Further information is requested label May 6, 2020
@klara31
Copy link
Author

klara31 commented May 6, 2020

config.js has a line for that:
BingMapsAPIKey = "xxxxxxxxxxx";
I already tried adding this line to config.js and that works OK.

mikenye added a commit that referenced this issue May 6, 2020
@mikenye mikenye removed the question Further information is requested label May 6, 2020
mikenye added a commit that referenced this issue May 6, 2020
Implement `BINGMAPSAPIKEY` for Issue #24
@mikenye
Copy link
Member

mikenye commented May 6, 2020

OK, the latest tag of the image should allow you to set BINGMAPSAPIKEY. Let me know how you fare.

@klara31
Copy link
Author

klara31 commented May 6, 2020

Yep, working! Thanks again!

@mikenye
Copy link
Member

mikenye commented May 6, 2020

You're most welcome!

@mikenye mikenye closed this as completed May 6, 2020
@klara31
Copy link
Author

klara31 commented Jul 22, 2020

The redirect to the user statistics page is gone...

@mikenye
Copy link
Member

mikenye commented Jul 22, 2020

I'll check it out

mikenye added a commit that referenced this issue Jul 22, 2020
mikenye added a commit that referenced this issue Jul 22, 2020
@mikenye
Copy link
Member

mikenye commented Jul 22, 2020

Ok this should now be fixed. Apologies for the inconvenience.

@klara31
Copy link
Author

klara31 commented Jul 22, 2020 via email

@mikenye mikenye closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants