Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'AdeptConnection' object has no attribute 'send_clock_jump' #150

Closed
idatum opened this issue Oct 21, 2023 · 7 comments
Closed

Comments

@idatum
Copy link

idatum commented Oct 21, 2023

I periodically see an exception running the latest image with piaware 8.2. Looks like a module version mismatch? I could not find any issue on piaware's repo. Here are my Docker logs:

[piaware] 2023/10/21 19:06:07 mlat-client(174): outlier detected with ts: 6269.091, last_ts: 6269.063, ts_elapsed: 0.027, sys_elapsed: 1.503 (values in seconds)
[piaware] 2023/10/21 19:06:07 mlat-client(174): Unexpected exception on connection to localhost:30005
[piaware] 2023/10/21 19:06:07 mlat-client(174): Traceback (most recent call last):
[piaware] 2023/10/21 19:06:07 mlat-client(174): File "/usr/lib/python3.11/asyncore.py", line 88, in read
[piaware] 2023/10/21 19:06:07 mlat-client(174): obj.handle_read_event()
[piaware] 2023/10/21 19:06:07 mlat-client(174): File "/usr/lib/python3.11/asyncore.py", line 425, in handle_read_event
[piaware] 2023/10/21 19:06:07 mlat-client(174): self.handle_read()
[piaware] 2023/10/21 19:06:07 mlat-client(174): File "/usr/local/lib/python3.11/dist-packages/MlatClient-0.4.2-py3.11-linux-x86_64.egg/mlat/client/receiver.py", line 214, in handle_read
[piaware] 2023/10/21 19:06:07 mlat-client(174): self.coordinator.input_received_messages(messages)
[piaware] 2023/10/21 19:06:07 mlat-client(174): File "/usr/local/lib/python3.11/dist-packages/MlatClient-0.4.2-py3.11-linux-x86_64.egg/mlat/client/coordinator.py", line 328, in input_received_messages
[piaware] 2023/10/21 19:06:07 mlat-client(174): handler(message, now)
[piaware] 2023/10/21 19:06:07 mlat-client(174): File "/usr/local/lib/python3.11/dist-packages/MlatClient-0.4.2-py3.11-linux-x86_64.egg/mlat/client/coordinator.py", line 350, in received_timestamp_jump_event
[piaware] 2023/10/21 19:06:07 mlat-client(174): self.server.send_clock_jump()
[piaware] 2023/10/21 19:06:07 mlat-client(174): ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[piaware] 2023/10/21 19:06:07 mlat-client(174): AttributeError: 'AdeptConnection' object has no attribute 'send_clock_jump'
[piaware] 2023/10/21 19:06:07 mlat-client(174): Lost connection to localhost:30005

@mutability
Copy link

this is caused by e305643 -- the Dockerfile is using the wrong mlat-client. piaware is not expecting / does not support use of wiedehopf's fork, please use mutability/mlat-client following what piaware_builder does.

@mutability
Copy link

I also opened wiedehopf/mlat-client#2 to see if we can reduce the confusion with different forks of mlat-client a bit.

kx1t added a commit that referenced this issue Nov 11, 2023
kx1t added a commit that referenced this issue Nov 11, 2023
@kx1t
Copy link
Member

kx1t commented Nov 11, 2023

fixed in 1157119

Thanks for doing the sleuthing to find which commit introduced the issue.

this is caused by e305643 -- the Dockerfile is using the wrong mlat-client. piaware is not expecting / does not support use of wiedehopf's fork, please use mutability/mlat-client following what piaware_builder does.

@kx1t kx1t closed this as completed Nov 11, 2023
@fredclausen
Copy link
Member

fredclausen commented Nov 11, 2023

Thanks for finding the issue so we could revert. Your version of the MLAT client was broken in bookworm based debian's - like our containers - because the python version was "too new" until this commit was merged in. Switching client's fixed the issue.

Sorry if this caused any issues for FlightAware MLAT results, but I wasn't aware wiedehopf's fork was "wrong" and that was patched appropriately to work on the version of python included in bookworm releases.

@idatum
Copy link
Author

idatum commented Nov 19, 2023

This is still an issue running v9.0

[piaware] 2023/11/19 21:28:42 mlat-client(174): outlier detected with ts: 34.368, last_ts: 99.340, ts_elapsed: -64.972, sys_elapsed: 2242.911 (values in seconds)
[piaware] 2023/11/19 21:28:42 mlat-client(174): Unexpected exception on connection to localhost:30005
[piaware] 2023/11/19 21:28:42 mlat-client(174): Traceback (most recent call last):
[piaware] 2023/11/19 21:28:42 mlat-client(174): File "/usr/lib/python3.11/asyncore.py", line 88, in read
[piaware] 2023/11/19 21:28:42 mlat-client(174): obj.handle_read_event()
[piaware] 2023/11/19 21:28:42 mlat-client(174): File "/usr/lib/python3.11/asyncore.py", line 425, in handle_read_event
[piaware] 2023/11/19 21:28:42 mlat-client(174): self.handle_read()
[piaware] 2023/11/19 21:28:42 mlat-client(174): File "/usr/local/lib/python3.11/dist-packages/MlatClient-0.4.2-py3.11-linux-x86_64.egg/mlat/client/receiver.py", line 214, in handle_read
[piaware] 2023/11/19 21:28:42 mlat-client(174): self.coordinator.input_received_messages(messages)
[piaware] 2023/11/19 21:28:42 mlat-client(174): File "/usr/local/lib/python3.11/dist-packages/MlatClient-0.4.2-py3.11-linux-x86_64.egg/mlat/client/coordinator.py", line 328, in input_received_messages
[piaware] 2023/11/19 21:28:42 mlat-client(174): handler(message, now)
[piaware] 2023/11/19 21:28:42 mlat-client(174): File "/usr/local/lib/python3.11/dist-packages/MlatClient-0.4.2-py3.11-linux-x86_64.egg/mlat/client/coordinator.py", line 350, in received_timestamp_jump_event
[piaware] 2023/11/19 21:28:42 mlat-client(174): self.server.send_clock_jump()
[piaware] 2023/11/19 21:28:42 mlat-client(174): ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[piaware] 2023/11/19 21:28:42 mlat-client(174): AttributeError: 'AdeptConnection' object has no attribute 'send_clock_jump'
[piaware] 2023/11/19 21:28:42 mlat-client(174): Lost connection to localhost:30005

@fredclausen
Copy link
Member

Just to be sure you've updated to the latest container?

@idatum
Copy link
Author

idatum commented Nov 19, 2023

Yes, my docker-compose.yaml:
image: ghcr.io/sdr-enthusiasts/docker-piaware:v9.0

docker logs piaware:
[piaware] 2023/11/19 22:10:45 piaware version 9.0 is running, process ID 143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants