Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check script doesn't support IPv6 #135

Closed
bootc opened this issue Dec 4, 2022 · 1 comment · Fixed by #136
Closed

Health check script doesn't support IPv6 #135

bootc opened this issue Dec 4, 2022 · 1 comment · Fixed by #136

Comments

@bootc
Copy link
Contributor

bootc commented Dec 4, 2022

I've been running this container in my Kubernetes cluster which has dual-stack networking, and the PiAware daemon happily connects to FlightAware using IPv6. Unfortunately the health check script's regexes exclude IPv6 addresses so the health check always fails.

In addition, netstat and other tools from the net-tools suite are deprecated; it would be better to switch to ss to get the same information.

I'll prepare a PR which fixes this.

bootc added a commit to bootc/docker-piaware that referenced this issue Dec 4, 2022
The net-tools package (netstat, ifconfig, etc...) are deprecated in
favour of their iproute2 equivalents (ss, ip, etc...). Replace netstat
usage with ss, removing many uses of regular expressions and gaining
IPv6 socker compatibility. Fixes sdr-enthusiasts#135.
bootc added a commit to bootc/docker-piaware that referenced this issue Dec 4, 2022
The net-tools package (netstat, ifconfig, etc...) are deprecated in
favour of their iproute2 equivalents (ss, ip, etc...). Replace netstat
usage with ss, removing many uses of regular expressions and gaining
IPv6 socket compatibility. Fixes sdr-enthusiasts#135.
mikenye pushed a commit that referenced this issue Feb 5, 2023
The net-tools package (netstat, ifconfig, etc...) are deprecated in
favour of their iproute2 equivalents (ss, ip, etc...). Replace netstat
usage with ss, removing many uses of regular expressions and gaining
IPv6 socket compatibility. Fixes #135.
@mikenye
Copy link
Member

mikenye commented Feb 5, 2023

Thanks so much, sorry it took so long to review & merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants