fix airspy_adsb service not stopping correctly #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'trap ... pkill ...' in the service script doesn't work, making s6 wait for the service indefinitely. This in turn runs into the 10 second docker stop / compose down timeout which will send a SIGKILL to the whole container leading to ungraceful termination. The trap will only work when there is no foreground program being executed by the shell, it does work however during a wait. Start airspy_adsb in the background and issue wait. Run the sleep delay in the background as well so we don't need to wait for it when the trap pkill happens. Should airspy_adsb error, the wait should limit program starts to every 10 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'trap ... pkill ...' in the service script doesn't work, making s6 wait for the service indefinitely. This in turn runs into the 10 second docker stop / compose down timeout which will send a SIGKILL to the whole container leading to ungraceful termination.
The trap will only work when there is no foreground program being executed by the shell, it does work however during a wait.
Start airspy_adsb in the background and issue wait. Run the sleep delay in the background as well so we don't need to wait for it when the trap pkill happens. Should airspy_adsb error, the wait should limit program starts to every 10 seconds.