Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to retrieve region factors for PoissonVI model #2529

Closed
duyguk opened this issue Feb 21, 2024 · 1 comment · Fixed by #2940
Closed

Unable to retrieve region factors for PoissonVI model #2529

duyguk opened this issue Feb 21, 2024 · 1 comment · Fixed by #2940

Comments

@duyguk
Copy link

duyguk commented Feb 21, 2024

Hi! I am unable to retrieve region factors with model.get_region_factors() for PoissonVI models (one trained on my own dataset, another trained on a subset of the tutorial PBMC data). The call instead returns the following error:

AttributeError: 'VAE' object has no attribute 'region_factors'

Versions:

1.1.1
1.1.0.post2

@duyguk duyguk added the bug label Feb 21, 2024
@martinkim0 martinkim0 added the P1 label Jul 12, 2024
@martinkim0 martinkim0 self-assigned this Jul 12, 2024
@martinkim0 martinkim0 added this to the scvi-tools 1.2 milestone Jul 12, 2024
@ori-kron-wis
Copy link
Collaborator

Originally This is a PEAKVI thing but PoissonVI didn't have get_region_factors cause it uses the VAE module.
I added that function to it.
There will be a fix for 1.2.0

@ori-kron-wis ori-kron-wis linked a pull request Aug 19, 2024 that will close this issue
canergen pushed a commit that referenced this issue Aug 19, 2024
This will close Issue
[2529](#2529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants