Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scully): add symbol support for plugins in places where ti was missing #735

Merged
merged 1 commit into from
Jul 13, 2020
Merged

fix(scully): add symbol support for plugins in places where ti was missing #735

merged 1 commit into from
Jul 13, 2020

Conversation

SanderElias
Copy link
Contributor

@SanderElias SanderElias commented Jul 12, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #731

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SanderElias SanderElias self-assigned this Jul 13, 2020
jorgeucano
jorgeucano approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@jorgeucano jorgeucano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanderElias SanderElias merged commit e3e28c7 into main Jul 13, 2020
@SanderElias SanderElias deleted the sander/fix731 branch July 13, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeucano jorgeucano jorgeucano approved these changes

Assignees

@SanderElias SanderElias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeErrors for @scullyio/scully-plugin-base-href-rewrite
2 participants
@SanderElias @jorgeucano