-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide --host flag for alternative hosts (otherwise scully not works) #87
Labels
enhancement
New feature or request
Comments
@jorgeucano is this replaced with the feature you are adding around |
@aaronfrost Yes, WIP |
SanderElias
added a commit
that referenced
this issue
Jan 16, 2020
on some computers, localhost isn't avaialble. This pr takes care of that by making the name to be used an setting closes #87
10 tasks
jorgeucano
pushed a commit
that referenced
this issue
Jan 16, 2020
* feat(hostname): puts in a hostname option on some computers, localhost isn't avaialble. This pr takes care of that by making the name to be used an setting closes #87 * docs(scully-configuration docs): update the docs to reflect new settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🧩 Feature request
Description
For some working environments, where localhost is by default not available to use (e.g. strict company VMs).
When I start
npm run scully
the mechanism tries to connecto tohttps://localhost:1864/_pong
. But this is not possible in my enviroment, because it redirects tohttps://myhost:1864/_pong
Describe the solution you'd like
Angular provides for ng serve a
--host
flag, this could be also a solution for you.The first line it crashed for me was here:
scully/scully/utils/waitForServerToBeAvailable.ts
Line 13 in 8ce6c13
But there are maybe also other points.
Describe alternatives you've considered
I tried to edit it directly in the source code. It worked until the next issue (no chromium available for my OS)
The text was updated successfully, but these errors were encountered: