Make a (shallow) copy of radarr/sonarr tags into a request before adding user tags #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-kennedy
requested review from
sct,
TheCatLady,
danshilm and
OwsleyJr
as code owners
OwsleyJr
approved these changes
Jun 9, 2023
|
@all-contributors pleases add @andrew-kennedy for code |
|
I've put up a pull request to add @andrew-kennedy! 🎉 |
|
🎉 This PR is included in version 1.33.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lenaxia
pushed a commit
to lenaxia/overseerr-oidc
that referenced
this pull request
Jan 3, 2024
…e adding user tags (sct#3485) * Make a (shallow) copy of radarr/sonarr tags into a request before adding user tags * Undo random formatting changes * more undoing formatting changes * Fix undefined case. * Prettier format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stops an issue where we were assigning the radarr/sonarr tags to another tags varable, and then mutating that variable with extra user tags (not realizing that this mutation altered the actual original settings tag array).
I don't have a test setup and made this PR through the web UI, so someone else will have to pull and validate it, but it should do the trick.