feat(ui): add episode shorthand to tv details UI (SxxExx)

[aedelbro]

Description

To provide the user more information concisely when viewing TV Details, this includes a "shorthand" for the episode SxxExx.  In the future, I'd like to add an on hover that shows the absolute episode number.

Screenshot (if UI-related)

As it currently stands:

With the shorthand badge:

To-Dos

• Successful build yarn build
• Translation keys yarn i18n:extract

References

Here's the discord discussion thread

Potential Issues

While testing a few other TV Shows, sometimes it shows the absolute number. I've so far only found 1 show where this happens, so it might be limited to just it.
When viewing One Piece, it shows the absolute episode number, instead of the episode number for just that season.
Example:

While it's not the end of the world, it's not desired (I think an on hover for absolute episode number would be best).

Additionally, it's not currently padding the episode or season number. That would require additional information to be returned to the UI, or significantly more logic. I could setup padding on the episode number within the season, but not between seasons.

[danshilm]

We were actually just talking about this a few days ago. The season number in the badge is redundant, so that's not needed. Just the episode number would be enough. But I'm not sure whether it would be better as just 1. <Episode Title> or in a badge.

As for the absolute episode number being shown, that's an issue for TMDB to deal with as far as I know. There is an absolute order numbering that's available on TMDB, so I'm really not sure why they're using the absolute numbering together with the seasons. Not ideal but well...

[sct]

Like @danshilm said. I think showing the season number again is redundant. We can keep it simple like 1. Episode Name.

[aedelbro]

While seasons with only 8-12 episodes, the Sxx is not really needed. However, if a user has multiple seasons open, with 60-80 episodes per season, it could be useful to know where you are in the scroll.

Additionally, if an absolute episode number is implemented later (my thought is on hover of the badge), do you have thoughts on how to implement that with just the number up front?

If we do decide to use just the episode number, I would say having it in text and not the badge would be best. ie 5 - Some episode title

[aedelbro]

@sct @danshilm any thoughts on the above?

Or just put the episode number in text up front and call it good?

[sct]

@sct @danshilm any thoughts on the above?

Or just put the episode number in text up front and call it good?

Sorry for the late reply. I think your argument about the season number being helpful in very long lists is one heck of an edge case but I don't mind it so much.

Looking at this again, I think my least favorite part is that we have a badge both before and after the title. Maybe moving the season/episode number badge next to the date would look better?

e: Or we could consider using different colors for the badge in front. Something feels weird about how its sandwiched in this.

[aedelbro]

@sct I agree on the sandwich feeling weird. I was really trying to make the badge work, as I'd really like the absolute episode number available in the future, and on hover of the badge feels like a natural way to do it. However, I feel like the episode number should be up front, and the air date info / badges feel like they should at the end.

In the interest of getting this out, I'll revert these commits, and just make the episode number show up front.

I feel like that's the easiest, quickest, least controversial change to get the episode number out, and the absolute number / badge / whatever can be addressed later if it ever comes back up.

[sct]

@sct I agree on the sandwich feeling weird. I was really trying to make the badge work, as I'd really like the absolute episode number available in the future, and on hover of the badge feels like a natural way to do it. However, I feel like the episode number should be up front, and the air date info / badges feel like they should at the end.

In the interest of getting this out, I'll revert these commits, and just make the episode number show up front.

I feel like that's the easiest, quickest, least controversial change to get the episode number out, and the absolute number / badge / whatever can be addressed later if it ever comes back up.

Sounds good. Let's start with that and see if we can improve afterwards.

[aedelbro]

@sct got the simple change made. I just kept it in the same title line for formatting.

ex:

[sct]

LGTM! Thank you!

[sct]

@all-contributors please add @aedelbro for code

[allcontributors]

@sct

I've put up a pull request to add @aedelbro! 🎉

[sct]

@holopin-bot @aedelbro add please :)

[holopin-bot]

Congratulations @aedelbro, you just earned a badge! Here it is: https://holopin.io/claim/clczkf4r8119208mmcb2l5qdg

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

[github-actions]

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

• v1.32.0
• GitHub release

Your semantic-release bot 📦🚀