Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update semantic-release to use proper arg for commit tag #3075

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Update semantic-release to use proper arg for commit tag #3075

merged 1 commit into from
Oct 18, 2022

Conversation

Eclipseop
Copy link
Contributor

Description

Update semantic-release to use GIT_SHA instead of GITHUB_SHA as per the build arguments documentation on semantic-release

Screenshot (if UI-related)

To-Dos

  • [N/A] Successful build yarn build
  • [N/A] Translation keys yarn i18n:extract
  • [N/A] Database migration (if required)

Issues Fixed or Closed

sct
sct approved these changes Oct 18, 2022
View reviewed changes
Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we don't use the SHA for anything in the stable images, I suppose it doesn't hurt to fix this! Thank you!

@sct sct enabled auto-merge (squash) October 18, 2022 23:10
@sct sct merged commit 76260f9 into sct:develop Oct 18, 2022
@sct
Copy link
Owner

sct commented Oct 19, 2022

@all-contributors please add @Eclipseop for code

@allcontributors allcontributors bot mentioned this pull request Oct 19, 2022
Merged
@allcontributors
Copy link
Contributor

@sct

I've put up a pull request to add @Eclipseop! 🎉

@github-actions
Copy link

🎉 This PR is included in version 1.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

lenaxia pushed a commit to lenaxia/overseerr-oidc that referenced this pull request Jan 3, 2024
@Eclipseop
build: update semantic-release to use proper arg for git sha (sct#3075)
54c628c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sct sct sct approved these changes

@TheCatLady TheCatLady Awaiting requested review from TheCatLady TheCatLady is a code owner

@danshilm danshilm Awaiting requested review from danshilm danshilm is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commit Tag on startup shows $GITHUB_SHA
2 participants
@Eclipseop @sct