Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notif): add Pushover sound options #2403

Merged
merged 4 commits into from
Oct 15, 2023
Merged

feat(notif): add Pushover sound options #2403

merged 4 commits into from
Oct 15, 2023

Conversation

TheCatLady
Copy link
Collaborator

Description

Adds setting option to allow configuration of Pushover notification sound.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@TheCatLady TheCatLady requested a review from sct as a code owner January 9, 2022 00:29
@TheCatLady TheCatLady force-pushed the feat/notif/pushover-sound branch 7 times, most recently from 0164873 to 02953f2 Compare January 20, 2022 13:59
@stale

This comment was marked as resolved.

Sign in to view
@stale stale bot added the stale label May 25, 2022
@TheCatLady TheCatLady removed the stale label May 26, 2022
@cypress
Copy link

cypress bot commented Aug 16, 2022 •
edited
Loading

Passing run #2115 ↗︎

0 28 0 0 Flakiness 0

Details:

feat(notif): add Pushover sound options
Project: overseerr Commit: 1817c743fb
Status: Passed Duration: 03:41 💡
Started: Oct 15, 2023 6:34 PM Ended: Oct 15, 2023 6:38 PM

Review all test suite changes for PR #2403 ↗︎

@TheCatLady TheCatLady force-pushed the feat/notif/pushover-sound branch 5 times, most recently from 975eb4c to 07cab35 Compare August 24, 2022 06:34
@stale

This comment was marked as outdated.

Sign in to view
@stale stale bot added the stale label Oct 28, 2022
@stale stale bot closed this Nov 9, 2022
@danshilm danshilm reopened this Dec 13, 2022
@stale stale bot removed the stale label Dec 13, 2022
@stale

This comment was marked as outdated.

Sign in to view
@stale stale bot added the stale label Feb 11, 2023
@danshilm danshilm removed the stale label Feb 14, 2023
@stale

This comment was marked as resolved.

Sign in to view
@stale stale bot added the stale label Apr 25, 2023
@danshilm danshilm removed the stale label Apr 25, 2023
@stale

This comment was marked as resolved.

Sign in to view
@stale stale bot added the stale label Jul 15, 2023
@danshilm danshilm removed the stale label Jul 16, 2023
@stale

This comment was marked as resolved.

Sign in to view
@stale stale bot added the stale label Sep 16, 2023
@stale stale bot closed this Oct 15, 2023
@danshilm danshilm removed the stale label Oct 15, 2023
@danshilm danshilm reopened this Oct 15, 2023
@danshilm danshilm enabled auto-merge (squash) October 15, 2023 19:05
@danshilm danshilm merged commit 3ea5076 into develop Oct 15, 2023
8 checks passed
@danshilm danshilm deleted the feat/notif/pushover-sound branch October 15, 2023 19:05
lenaxia pushed a commit to lenaxia/overseerr-oidc that referenced this pull request Jan 3, 2024
@TheCatLady @danshilm
feat(notif): add Pushover sound options (sct#2403)
e421ac4 
Co-authored-by: Danshil Kokil Mungur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danshilm danshilm danshilm approved these changes

@sct sct Awaiting requested review from sct sct is a code owner

@OwsleyJr OwsleyJr Awaiting requested review from OwsleyJr OwsleyJr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Pushover extended options
2 participants
@TheCatLady @danshilm