Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notif): Restyle HTML email notifications #1864

Merged
merged 17 commits into from
Jul 14, 2021

Conversation

tangentThought
Copy link
Contributor

@tangentThought tangentThought commented Jul 3, 2021

Description

Current email notifications are unstyled. Restyled email notifications to better match the Overseerr theme.

  • Resembles request cards from Overseerr
  • Added logo header to the email
  • Lightly-optimized for mobile

Screenshot

image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract

@tangentThought tangentThought changed the title Restyle HTML email notifications feat(notif): Restyle HTML email notifications Jul 3, 2021
@tangentThought tangentThought marked this pull request as ready for review July 3, 2021 06:08
@tangentThought tangentThought requested a review from sct as a code owner July 3, 2021 06:08
Copy link
Collaborator

@TheCatLady TheCatLady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! 👍🏻

server/templates/email/media-request/html.pug Outdated Show resolved Hide resolved
server/templates/email/media-request/html.pug Show resolved Hide resolved
server/templates/email/media-request/html.pug Outdated Show resolved Hide resolved
server/templates/email/media-request/html.pug Outdated Show resolved Hide resolved
tangentThought and others added 4 commits July 5, 2021 11:33
Incorporated font and action Url change suggestions.
Added padding-right to timestamp field
Copy link
Collaborator

@TheCatLady TheCatLady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more small tweaks for consistency with the app 😸

server/templates/email/media-request/html.pug Outdated Show resolved Hide resolved
server/templates/email/media-request/html.pug Outdated Show resolved Hide resolved
server/templates/email/media-request/html.pug Outdated Show resolved Hide resolved
server/templates/email/media-request/html.pug Outdated Show resolved Hide resolved
@sct
Copy link
Owner

sct commented Jul 13, 2021

Hi @tangentThought this is super rad. Thank you so much! Sorry for the wait. Things have been very hectic IRL. Can you rebase this for me? I will get it reviewed after and we can get it merged!

Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much!

@sct sct merged commit badf0f5 into sct:develop Jul 14, 2021
@sct
Copy link
Owner

sct commented Jul 14, 2021

@allcontributors please add @tangentThought for code

@allcontributors
Copy link
Contributor

@sct

I've put up a pull request to add @tangentThought! 🎉

nicospz pushed a commit to nicospz/overseerr that referenced this pull request Aug 9, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants