add request count to max requests close reason #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 11 11
Lines 812 812
=======================================
Hits 801 801
Misses 11 11
|
|
I am not sure about it, but not against it either. |
kmike
reviewed
Dec 18, 2023
| @@ -108,7 +108,9 @@ def process_request(self, request, spider): | |||
| slot.delay = 0 | |||
|
|
|||
| if self._max_requests_reached(downloader): | |||
| self._crawler.engine.close_spider(spider, "closespider_max_zapi_requests") | |||
| self._crawler.engine.close_spider( | |||
| spider, f"closespider_max_{self._max_requests}_zapi_requests" | |||
There was a problem hiding this comment.
I think it's better to have the close reasons static, so that they are not unique each run. If we need any additional information, then stats look like a better place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the list of spider jobs in Scrapy Cloud, there's a column dictating the spider's
close_reasonmessage. Some users have raised that it's not apparently clear from this view about the max request that was set.What do you think about including the set number of max requests to the spider
close_reasonmessage?