Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster fingerprints #68

Merged
merged 5 commits into from
Apr 19, 2016
Merged

Faster fingerprints #68

merged 5 commits into from
Apr 19, 2016

Conversation

kmike
Copy link
Member

@kmike kmike commented Apr 19, 2016

This should fix #65.

For a nested dict with 30Kb string value _fast_hash is about 3-4x faster than _json_based_hash(_process(value, sha=True)), and the latter is about 3-4x faster than _json_based_hash(value). Because with cache_args it is expected to have a very large amount of duplicates I went with this complicated solution.

@codecov-io
Copy link

Current coverage is 89.96%

Merging #68 into master will increase coverage by +0.36% as of 8bf3a9a

@@            master     #68   diff @@
======================================
  Files            9       9       
  Stmts          529     548    +19
  Branches       100     107     +7
  Methods          0       0       
======================================
+ Hit            474     493    +19
  Partial         26      26       
  Missed          29      29       

Review entire Coverage Diff as of 8bf3a9a

Powered by Codecov. Updated on successful CI builds.

@kmike kmike merged commit bc8ddfd into master Apr 19, 2016
@kmike kmike deleted the faster-fingerprints branch January 16, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json_based_hash is slow
2 participants