Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scrapy.utils.request.fingerprint #311

Conversation

DharmeshPandav
Copy link

@Gallaecio
Copy link
Contributor

While this removes the warning, it is a backward incompatible change (it removes a public function), and is not the ideal way to address this.

The ideal way would be to provide a new fingerprinting class that users can assign to the new REQUEST_FINGERPRINTER_CLASS Scrapy setting. See Writing your own request fingerprinter for details.

If we provide such a class, we can replace steps 4 and 5 of the scrapy-splash configuration, and deprecate (not remove, otherwise we break backward compatibility) those 2 custom components provided in scrapy-splash, as well as the fingerprint function that you renamed and reimplemented here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants