Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github action badge #295

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Fix github action badge #295

merged 3 commits into from
Oct 18, 2021

Conversation

Laerte
Copy link
Contributor

@Laerte Laerte commented Oct 6, 2021

Fix github action badge link

@Gallaecio
Copy link
Contributor

@elacuesta I copied the badge URL from https://github.com/scrapy/itemadapter, where it is working. But I did indeed forgot to check that it worked here, and I have no idea why it works there.

Does the itemadapter badge does what I think and covers all workflows in a single badge? If so, how to do the same here?

@elacuesta
Copy link
Member

elacuesta commented Oct 6, 2021

Well, to be honest, I don't really know either 😅 (see the comment below)
It might be time to change the badge for itemadapter too.

@elacuesta
Copy link
Member

elacuesta commented Oct 6, 2021

It seems to me like workflow names are accepted (for itemadapter those would be "Checks", "Publish", "Tests"). We had them all consolidated under "Build" some time ago, so I think the reason it works is because it's an old badge, it's really not a valid badge for the current status.

elacuesta added a commit to scrapy/itemadapter that referenced this pull request Oct 6, 2021
@Laerte
Copy link
Contributor Author

Laerte commented Oct 6, 2021

@elacuesta You are right, this is the commit that "Build" are deprecated. scrapy/itemadapter@2735ff3#diff-87ee5504a3e25ac558b343724c905f2f7949e8cec3d92b9c4300bb922afa164f

@Gallaecio Should i change and just leave "Tests" badge?

@Gallaecio
Copy link
Contributor

@Gallaecio Should i change and just leave "Tests" badge?

I think so. I mean, if the Publish job ever fails, that’s something we would fix within minutes.

@Laerte
Copy link
Contributor Author

Laerte commented Oct 7, 2021

@Gallaecio Done.

@Laerte Laerte changed the title fix badges images Fix github action badge Oct 7, 2021
@elacuesta elacuesta merged commit f5273b3 into scrapy-plugins:master Oct 18, 2021
@Laerte Laerte deleted the fix/update-badges branch October 18, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants