Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] more tests, fix cookie handling #156

Merged
merged 5 commits into from
Jan 16, 2018
Merged

[WIP] more tests, fix cookie handling #156

merged 5 commits into from
Jan 16, 2018

Conversation

kmike
Copy link
Member

@kmike kmike commented Jan 13, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jan 13, 2018

Codecov Report

Merging #156 into master will increase coverage by 0.54%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   90.03%   90.57%   +0.54%     
==========================================
  Files           9        9              
  Lines         572      573       +1     
  Branches      115      115              
==========================================
+ Hits          515      519       +4     
- Misses         29       31       +2     
+ Partials       28       23       -5
Impacted Files Coverage Δ
scrapy_splash/middleware.py 87.73% <100%> (+2.73%) ⬆️
scrapy_splash/utils.py 89.23% <0%> (-7.7%) ⬇️
scrapy_splash/dupefilter.py 90.9% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa07ba0...38710f6. Read the comment docs.

@kmike kmike changed the title [WIP] more tests [WIP] more tests, fix cookie handling Jan 13, 2018
@kmike kmike merged commit 6c1783e into master Jan 16, 2018
@kmike kmike deleted the more-tests branch January 16, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant