-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An example of http_method and body in splash script #49
Comments
Ah, this example is missing |
Yeah, this makes sense. For all other endpoints HTTP status code is handled for As for DefaultExecuteSplashRequest, it looks related to scrapinghub/splash#283; I wonder if we should provide a way to use scripts stored in separate .lua files in SplashExecuteRequest or SplashLuaRequest (or in SplashRequest directly). |
Ah, I missed that error support, this is nice! I like the SplashExecuteRequest idea. Making it all composable looks really hard though. |
As for covering this in the documentation, shouldn’t it be done in the Splash documentation instead? |
There are examples of using cookies in the docs, but no examples of setting method and body. I think it would be useful to add it, or perhaps even add the following class (with a better name): with it is possible to use full capabilities of scrapyjs without digging into splash scripts:
The text was updated successfully, but these errors were encountered: