Fix splash browser tab storing wrong html #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user loaded a page, Then loaded a different page, then went back to the initial page, then created a sample the html stored in the `original_body.html` file may have been incorrect. This is caused by the html being stored during `reply_read` phase of the network manager which is not called on a subsequent page load due to caching. The solution used here is just to reload the page if the html is incorrect, this is found through comparing the url in the frame and in the network manager Other Changes: Send page metadata to the UI on page load finished Do no evaljs or load page url if the tab is in a closing state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user loaded a page, Then loaded a different page, then went back to the
initial page, then created a sample the html stored in the
original_body.htmlfile may have been incorrect. This is caused by the html being stored during
reply_readphase of the network manager which is not called on a subsequentpage load due to caching. The solution used here is just to reload the page
if the html is incorrect, this is found through comparing the url in the frame
and in the network manager
Other Changes:
Send page metadata to the UI on page load finished
Do no evaljs or load page url if the tab is in a closing state