Update verbose logic with ternary operators

lib/music_theory/note.rb

@@ -8,9 +8,8 @@ class Note
  attr_accessor :frequency, :pitch, :duration, :output_file_name, :distort
 
  def initialize(options = {})
- @frequency = options[:frequency] || 440.0 # Note frequency in Hz
- @pitch = options[:pitch] # ex: Pitch.new(:Fs, 4) -> (pitch, octave)
- @frequency = evaluate_frequency
+ @frequency = options[:pitch] ? options[:pitch].frequency
+ : options[:frequency].to_f || 440 # pitch ex) Pitch.new(:Ds, 3)
  @duration = options[:duration] || 1.0 # Number of seconds per note
  @distort = options[:distort] || false
  @output_file_name = options[:output_file_name] || 'note' # File name to write (without extension)
@@ -54,15 +53,5 @@ def distort!(samples)
  sample /= 8.to_f
  end
  end
-
- private
-
- def evaluate_frequency
- if @pitch
- @pitch.frequency
- else
- @frequency.to_f
- end
- end
  end
 end

lib/music_theory/pitch.rb

@@ -57,11 +57,7 @@ def replace_sharp_or_flat(note)
 
  def prepare_note_for_offset_map(note)
  letter = note[0].upcase
- accidental = if note[1] then
- note[1].downcase
- else
- ""
- end
+ accidental = note[1] ? note[1].downcase : ""
  "#{letter}#{accidental}".to_sym
  end
 end