Some new functionality #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Mod UI changes. updated mainform.cs to be able to handle the new mod buttons.
updates and such. Hopefully.
Decided against having it. Mostly because I was able to get the bar on the right to hold the mod stuff.
save is currently limited by the fact that the input box checks the ARCHIVE directory only. It wasn't designed to look anywhere. Strange.
Allows the inputbox to validate against Mods as well.
added and binded hostsModView
updated the name to "View Archives/Mods" to accurately reflect its function.
It could be confusing to the user if nothing appears to happen. So a message box alerts the user that it's done.
Also got the main mod list to refresh to show the changes.
regex has a problem recognizing multiple results when they are on the same line. By forcing a newline, the regex pattern recognizer will grab all the results. This also let me find that the [To Parent Directory] was recognized as a match. I've hard coded a removal of that result. hope it's not too big of a problem later on.
|
Thanks! It looks like our line endings are different so the GitHub diff isn't working so well and I can't figure out the changes easily. Sorry, that's my bad since I'm new to Git as well so I normalized the line endings and added a .gitattributes file but I'm not sure how to reconcile your pull request's line endings now. I'll have to do a little more research and see what I should do. I did a quick clone of your fork and ran the program and noticed a few things:
If you could fix those issues that would be great, otherwise no worries, when I have some time I'll look into your changes in more detail and see if I can resolve the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just wanted to offer back the change that I've made. I needed to be able to swap out just portions of a hosts file, so I made a Mods section. I also needed to download the mods from the webpage, so I added that too. In retrospect, I probably should have made them two separate branches, but I'm still trying to get the hang of Git.
Thanks,
Jacob Hitze