Add support for moving messages to another region #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottjbarr
requested changes
Aug 28, 2018
There was a problem hiding this comment.
Hi @panga
Thanks for the PR, it looks good.
A couple of minor changes requested before I accept the PR.
Cheers,
Scott
main.go
Outdated
| os.Exit(1) | ||
| } | ||
| log.Printf("source queue url: %v", *src) | ||
| log.Printf("destination queue url: %v", *dest) |
There was a problem hiding this comment.
Please remove the output lines.
|
|
||
| func getRegionFromQueueURL(url string) string { | ||
| return strings.Split(url, ".")[1] | ||
| } |
There was a problem hiding this comment.
New line at end of file please :)
README.md
Outdated
| The `AWS_SECRET_ACCESS_KEY`, `AWS_ACCESS_KEY_ID`, and ,`AWS_REGION` | ||
| environment variables must be set. | ||
|
|
||
| The `AWS_SECRET_ACCESS_KEY` and `AWS_ACCESS_KEY_ID` environment variables must be set, except for EC2 instances with IAM roles. | ||
|
|
There was a problem hiding this comment.
Please remove the reference to EC2, and keep line length < 80 chars.
scottjbarr
approved these changes
Aug 29, 2018
|
Thanks @panga ! |
scottjbarr
added a commit
that referenced
this pull request
Oct 24, 2018
This reverts commit ab52f23.
|
This has been reverted due to #9 |
|
@scottjbarr are you sure? I'm using it in production without any issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@scottjbarr