-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds "proxy" functionality to s3ninja. #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to configure an upstream connection which is used if an object is not found locally. Fixes: MISC-16
Fixes: MISC-16
Fixes: MISC-16
meg1502
suggested changes
Apr 28, 2022
Fixes: MISC-16
andyHa
reviewed
Apr 28, 2022
Checks isConfigured before using Fixes: MISC-16
jakobvogel
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very, very cool 🤩
sabieber
approved these changes
Apr 28, 2022
Fixes: MISC-16
sabieber
approved these changes
Apr 28, 2022
mkeckmkeck
approved these changes
Apr 29, 2022
cschierle
approved these changes
Apr 29, 2022
(The changes requested by @meg1502 have been implemented.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An upstream s3 instance can be configured.
If configured all fetching requests, which can not be satisfied with by the s3-ninja itself, will internally be requested from the upstream instance.
Put and Delete operations are only performed on the s3ninja and will never be send to the upstream instance.