Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "proxy" functionality to s3ninja. #197

Merged
merged 6 commits into from
Apr 30, 2022
Merged

Adds "proxy" functionality to s3ninja. #197

merged 6 commits into from
Apr 30, 2022

Conversation

ReadMails-ReallyFast
Copy link
Contributor

An upstream s3 instance can be configured.

If configured all fetching requests, which can not be satisfied with by the s3-ninja itself, will internally be requested from the upstream instance.

Put and Delete operations are only performed on the s3ninja and will never be send to the upstream instance.

Allows to configure an upstream connection which is used if an object is not found locally.

Fixes: MISC-16
src/main/java/ninja/AwsUpstream.java Outdated Show resolved Hide resolved
src/main/java/ninja/AwsUpstream.java Outdated Show resolved Hide resolved
src/main/java/ninja/AwsUpstream.java Outdated Show resolved Hide resolved
Checks isConfigured before using

Fixes: MISC-16
Copy link
Member

@jakobvogel jakobvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very, very cool 🤩

src/main/java/ninja/AwsUpstream.java Outdated Show resolved Hide resolved
src/main/java/ninja/AwsUpstream.java Outdated Show resolved Hide resolved
src/main/java/ninja/S3Dispatcher.java Outdated Show resolved Hide resolved
src/main/java/ninja/S3Dispatcher.java Outdated Show resolved Hide resolved
src/main/java/ninja/S3Dispatcher.java Outdated Show resolved Hide resolved
src/main/java/ninja/AwsUpstream.java Outdated Show resolved Hide resolved
src/main/java/ninja/AwsUpstream.java Show resolved Hide resolved
src/main/java/ninja/AwsUpstream.java Outdated Show resolved Hide resolved
src/main/java/ninja/AwsUpstream.java Outdated Show resolved Hide resolved
src/main/java/ninja/S3Dispatcher.java Outdated Show resolved Hide resolved
src/main/java/ninja/S3Dispatcher.java Outdated Show resolved Hide resolved
@jakobvogel
Copy link
Member

(The changes requested by @meg1502 have been implemented.)

@jakobvogel jakobvogel merged commit dcc1df8 into develop Apr 30, 2022
@jakobvogel jakobvogel deleted the mju/proxy branch April 30, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants