-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade wrapper generator script and regenerate bindings #186
Conversation
Note that the generation process was not totally automatic in our case, see #77 . We also pinned |
With this PR, the generation process should be totally automatic. Missing definitions are all macro-related and one can manually add them to Variadic functions can be supported by using Julia 1.5's |
As SCIP doesn't use duplicated enum members, so I just completely remove the use of |
OK, so That's a great improvement and will help a lot to keep up with API changes in SCIP in the future! |
this is fantastic yes |
Co-authored-by: Mathieu Besançon <[email protected]>
@matbesancon @rschwarz This is ready for another round of review. As for the test failures, I guess I did something wrong when solving the conflict. Feel free to edit this PR if needed. I'm going to merge the Clang.jl#278 this weekend and after that, you can run the generator on your own machine with Clang.jl#master. |
I won't keep updating this PR but will keep monitoring the compatibility of the generated code here. |
thanks for the work on this! So the current PR is based on what is currently on Clang.jl master right? |
Yes. It's recommended to use Clang.jl#master from now on. |
there seems to be some conversion error: |
This has been fixed in eba7eff, but I did something wrong when solving the conflict, so it's not in the latest commit. I believe you could fix this by cherry-pick that commit or just simply fix it with a new one. |
@Gnimuc do you know when a release will be tagged on Clang.jl? Depending on master is a bit dangerous as next commits can break things |
This package is being monitored in https://github.com/Gnimuc/GeneratorScripts, it's safe to just use the master branch. |
Actually, this PR bundles the Modifest.toml, so it will always use the same version of Clang.jl unless someone does a |
@Gnimuc should we bump the gen/Project.toml to the latest 0.11 you released? |
0.11? you mean 0.14? No, 0.14 has not been officially released yet. The latest master has some new features like variadic function support, docstrings dumping, etc. If you'd like to update to the latest master, run |
ok thank you, we do not need this for now so merging |
I'm testing JuliaInterop/Clang.jl#278. Before making a new release for Clang.jl, I'd like to make sure that the code generated by the new generator is not broken. Any feedback about the new generator would be highly appreciated.