Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Always download latest Miniconda for Travis jobs #8857

Merged
merged 4 commits into from
May 11, 2017
Merged

[MRG] Always download latest Miniconda for Travis jobs #8857

merged 4 commits into from
May 11, 2017

Conversation

naoyak
Copy link
Contributor

@naoyak naoyak commented May 11, 2017 •
edited
Loading

Ref: #8855 (comment)

Travis builds using conda have been downloading a version of Miniconda from 2014 before running conda update conda. This change makes sure that it instead downloads the Miniconda version corresponding to the latest Anaconda release and overwrites any cached miniconda.sh.

ping @lesteve

@naoyak naoyak mentioned this pull request May 11, 2017
Merged
lesteve
lesteve reviewed May 11, 2017
View reviewed changes
Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

build_tools/travis/install.sh Outdated
wget https://repo.continuum.io/miniconda/Miniconda-3.6.0-Linux-x86_64.sh \
-O miniconda.sh
if [[ ! -f miniconda.sh ]]; then
if [[ "$PYTHON_VERSION" == "2.7" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would always download the Miniconda3 installer and use -p /home/travis/miniconda

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the Miniconda3 installer works under py2.7? Interesting..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh duh, it doesn't matter since you're specifying a Python version when creating the env. whoops

build_tools/travis/install.sh Outdated
chmod +x miniconda.sh && ./miniconda.sh -b
cd ..
export PATH=/home/travis/miniconda/bin:$PATH
Copy link
Member

@lesteve lesteve May 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep these two lines

Copy link
Contributor Author

@naoyak naoyak May 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want conda update -y conda, instead of pinning conda to the version corresponding to the latest "official" release from Continuum? I suppose it can't hurt..

@naoyak
Copy link
Contributor Author

naoyak commented May 11, 2017 •
edited
Loading

The cached miniconda.sh needs to be cleared on Travis.

@lesteve
Copy link
Member

lesteve commented May 11, 2017

The cached miniconda.sh needs to be cleared on Travis.

I'll do it. To be honest the caching of miniconda.sh is premature optimization. It takes less than 3s on my computer ...

@naoyak naoyak changed the title Use latest Miniconda for Travis jobs [MRG] Use latest Miniconda for Travis jobs May 11, 2017
@lesteve
Copy link
Member

lesteve commented May 11, 2017

I checked in joblib and the download of the miniconda installer takes less than 1s on Travis. We should really remove the caching of miniconda.sh. Bonus points if you do it in this PR!

@naoyak
Copy link
Contributor Author

naoyak commented May 11, 2017

@lesteve great, this should be ready to go!

@naoyak naoyak changed the title [MRG] Use latest Miniconda for Travis jobs [MRG] Always download latest Miniconda for Travis jobs May 11, 2017
@lesteve
Copy link
Member

lesteve commented May 11, 2017

I put back the debugging echo statement and pushed into your branch. This is just to keep the diff simple.

Having said that I think the download folder was only used for miniconda.sh so I'll probably do a PR later to remove the logic + caching from Travis and Circle.

@lesteve
Copy link
Member

lesteve commented May 11, 2017

Travis passed, I am going to go ahead and merge this one. Thanks @naoyak !

@lesteve lesteve merged commit b9e7614 into scikit-learn:master May 11, 2017
@naoyak naoyak deleted the travis-conda-latest branch May 11, 2017 12:34
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this pull request Jun 14, 2017
@naoyak @Sundrique
[MRG] Always download latest Miniconda on Travis (scikit-learn#8857)
d3360e9
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@naoyak @dmohns
[MRG] Always download latest Miniconda on Travis (scikit-learn#8857)
39f2732
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@naoyak @dmohns
[MRG] Always download latest Miniconda on Travis (scikit-learn#8857)
135914b
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@naoyak @NelleV
[MRG] Always download latest Miniconda on Travis (scikit-learn#8857)
f99a045
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@naoyak @paulha
[MRG] Always download latest Miniconda on Travis (scikit-learn#8857)
6bfec1a
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@naoyak @AishwaryaRK
[MRG] Always download latest Miniconda on Travis (scikit-learn#8857)
07fea45
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@naoyak @maskani-moh
[MRG] Always download latest Miniconda on Travis (scikit-learn#8857)
f6a675c
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@naoyak
[MRG] Always download latest Miniconda on Travis (scikit-learn#8857)
26eaa48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naoyak @lesteve