Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add polars to the requirements for building documentation #28724

Merged

Conversation

miguelcsilva
Copy link
Contributor

Reference Issues/PRs

Fixes #28669

What does this implement/fix? Explain your changes.

Adds polars to the documentation as a required dependency to build the documentation.

Any other comments?

Another issue is mentioned in the discussion as something also needing resolving #28669 (comment), however my understanding is that it was not blocking for adding the dependency in the documentation.

@miguelcsilva miguelcsilva changed the title Add polars to building the documentation Add polars to the requirements for building documentation Mar 29, 2024
Copy link

github-actions bot commented Mar 29, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: dac452e. Link to the linter CI: here

@miguelcsilva miguelcsilva changed the title Add polars to the requirements for building documentation DOC Add polars to the requirements for building documentation Mar 29, 2024
@miguelcsilva miguelcsilva changed the title DOC Add polars to the requirements for building documentation [MRG] Add polars to the requirements for building documentation Mar 29, 2024
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @miguelcsilva

@jeremiedbb
Copy link
Member

Another issue is mentioned in the discussion as something also needing resolving #28669 (comment), however my understanding is that it was not blocking for adding the dependency in the documentation.

I think it means that polars should also be added as doc dependency in pyproject.toml here

docs = [

I also notices that polars is only listed as test dependency in _min_dependencies.py, see

"polars": ("0.19.12", "tests"),

It should also be updated with doc.

It can be done in this PR or in a separate one. Ping @lesteve.

@miguelcsilva
Copy link
Contributor Author

Thanks @jeremiedbb. Updated the PR to add polars as a dependency in both places you mentioned

@lesteve lesteve changed the title [MRG] Add polars to the requirements for building documentation DOC Add polars to the requirements for building documentation Apr 2, 2024
@lesteve lesteve enabled auto-merge (squash) April 2, 2024 09:38
@lesteve
Copy link
Member

lesteve commented Apr 2, 2024

Thanks! I pushed a very minor tweak and set auto-merge, so that this PR will be merged automatically when CI is green.

@lesteve lesteve merged commit 65ba91b into scikit-learn:main Apr 2, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polars not mentioned as requirement to build documentation
3 participants