Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Parameters validation for sklearn.utils.safe_mask #26131

Merged
merged 11 commits into from
Jun 27, 2023

Conversation

elabongaatuo
Copy link
Contributor

@elabongaatuo elabongaatuo commented Apr 8, 2023

Towards #24862

🤖 Generated by Copilot at 8894959

This pull request enhances the parameter validation of sklearn.utils.safe_mask, a function that creates a boolean mask from an array-like object. It adds the function to the test suite of public functions, and applies the validate_params decorator to check the input types.

@jeremiedbb jeremiedbb added No Changelog Needed Validation related to input validation labels Apr 12, 2023
@elabongaatuo
Copy link
Contributor Author

hello @glemaitre , i made the recommended changes. please do review. thank you :)

@elabongaatuo
Copy link
Contributor Author

hello @glemaitre . i hope you have been well, i would appreciate if you would review my PR. thank you

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: fd0748e. Link to the linter CI: here

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @elabongaatuo

@jeremiedbb jeremiedbb enabled auto-merge (squash) June 27, 2023 15:20
@jeremiedbb jeremiedbb merged commit e490da9 into scikit-learn:main Jun 27, 2023
26 checks passed
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants