MNT Adds dict typing hint to _parameter_constraints for mypy #24301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
changed the title
|
@thomasjpfan - I think it would be a good idea to update the example code for the declaration in this issue for contributors going forward:
|
jjerphan
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
LGTM. Thank you, @thomasjpfan.
Thank you for your remark, @stefmolin. I think we can modify the issue description then this PR is merged.
jeremiedbb
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
dicttyping hint to_parameter_constraints, which means we do not need to write# type: ignoreanymore.If we only want to avoid the
# type: ignoreswe have right now, then not every_parameter_constraintsrequiresdict. I added them all in this PR because it is more consistent and makes it easier for contributors.