Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Use cimport numpy as cnp for sklearn/decomposition #23330

Merged
merged 1 commit into from
May 12, 2022

Conversation

RMeli
Copy link
Contributor

@RMeli RMeli commented May 11, 2022

Reference Issues/PRs

Addresses #23295 (sklearn/decomposition)

What does this implement/fix? Explain your changes.

Change np to cnp to reference NumPy's C API according to issue #23295 for sklearn/decomposition/*.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit f09f748 into scikit-learn:main May 12, 2022
@RMeli RMeli deleted the 23295-decomposition branch May 12, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants