DOC, MNT Typos found by codespell #22906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
approved these changes
Mar 20, 2022
|
Thanks @DimitriPapadopoulos |
peternewman
reviewed
Mar 21, 2022
| @@ -46,7 +46,7 @@ if [[ -n "$CHECK_WARNINGS" ]]; then | |||
| # numpy's 1.19.0's tostring() deprecation is ignored until scipy and joblib removes its usage | |||
| TEST_CMD="$TEST_CMD -Werror::DeprecationWarning -Werror::FutureWarning -Wignore:tostring:DeprecationWarning" | |||
|
|
|||
| # Python 3.10 deprecates disutils and is imported by numpy interally during import time | |||
| # Python 3.10 deprecates distutils and is imported by numpy integrally during import time | |||
There was a problem hiding this comment.
The codespell suggestion of "internally" seems more likely here.
There was a problem hiding this comment.
Ah, it makes sense after re-reading it. Fixed by #22912.
There was a problem hiding this comment.
I've done a PR in Codespell to add your suggestion too though! codespell-project/codespell#2316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Fix new typos found by codespell.
Any other comments?
Changelog probably not needed.
I hope the standart → standard change is OK. I was wondering whether Standart is a name, but it doesn't look like it is, just a typo.