Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Fixes pytest by using deprecated_modules #15291

Merged
merged 9 commits into from
Oct 18, 2019
Merged

[MRG] Fixes pytest by using deprecated_modules #15291

merged 9 commits into from
Oct 18, 2019

Conversation

thomasjpfan
Copy link
Member

Alternative to #15283

This PR uses deprecated_modules.py to update collect_ignore_glob.

@thomasjpfan
Copy link
Member Author

@NicolasHug @adrinjalali This was what I was thinking about. I prefer this one because it does not need to add the paths to yet another location.

NicolasHug
NicolasHug approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all goes green

adrinjalali
adrinjalali approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @thomasjpfan

@adrinjalali adrinjalali merged commit 56edce8 into scikit-learn:master Oct 18, 2019
@adrinjalali adrinjalali mentioned this pull request Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasjpfan @NicolasHug @adrinjalali