Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display version string #452

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Display version string #452

merged 3 commits into from
Jul 23, 2024

Conversation

micahflee
Copy link
Collaborator

@micahflee micahflee commented Jul 23, 2024

This PR displays the version string in the footer of the template, like "Powered by Hush Line 0.1.10". The important change is this:

Each time you make a release, you must define the release version in hushline/version.py before creating the git tag.

What I recommend is for each release, we do the following:

  • Create a release PR, like "Version 0.1.11" which includes the updated version string in hushline/version.py
  • After the PR is merged, make a release tag

image

…sk app config, and display the version in the template footer
@micahflee micahflee added the deploy create dev deployment label Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

Terraform plan in terraform/dev in the hushline-dev-display-version workspace

With variables

branch = "display-version"
name   = "hushline-dev-display-version"
Plan: 2 to add, 0 to change, 0 to destroy. Changes to Outputs.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create

Terraform will perform the following actions:

  # digitalocean_project.hush_line_dev will be created
+   resource "digitalocean_project" "hush_line_dev" {
+       created_at  = (known after apply)
+       description = "Development instance based on the display-version branch"
+       environment = "Development"
+       id          = (known after apply)
+       is_default  = false
+       name        = "hushline-dev-display-version"
+       owner_id    = (known after apply)
+       owner_uuid  = (known after apply)
+       purpose     = "Web Application"
+       resources   = (known after apply)
+       updated_at  = (known after apply)
    }

  # module.app.digitalocean_app.app will be created
+   resource "digitalocean_app" "app" {
+       active_deployment_id = (known after apply)
+       created_at           = (known after apply)
+       default_ingress      = (known after apply)
+       id                   = (known after apply)
+       live_url             = (known after apply)
+       project_id           = (known after apply)
+       updated_at           = (known after apply)
+       urn                  = (known after apply)

+       dedicated_ips (known after apply)

+       spec {
+           domains  = (known after apply)
+           features = [
+               "buildpack-stack=ubuntu-22",
            ]
+           name     = "hushline-dev-display-version"
+           region   = "sfo"

+           alert {
+               disabled = false
+               rule     = "DEPLOYMENT_FAILED"
            }

+           domain (known after apply)

+           ingress (known after apply)

+           service {
+               dockerfile_path    = "Dockerfile"
+               http_port          = 8080
+               instance_count     = 1
+               instance_size_slug = "apps-s-1vcpu-0.5gb"
+               internal_ports     = (known after apply)
+               name               = "app"
+               run_command        = (known after apply)

+               github {
+                   branch         = "display-version"
+                   deploy_on_push = true
+                   repo           = "scidsg/hushline"
                }

+               health_check {
+                   http_path = "/health.json"
                }

+               routes (known after apply)
            }
        }
    }

Plan: 2 to add, 0 to change, 0 to destroy.

Changes to Outputs:
+   app_live_url = (known after apply)

❌ Error applying plan in Deploy/Destroy Branch Dev Environment #156

@micahflee micahflee marked this pull request as draft July 23, 2024 17:46
@micahflee
Copy link
Collaborator Author

The dev deploy failed on the first commit but succeeded on the second commit. You can see it live here: https://hushline-dev-display-version-dnhhz.ondigitalocean.app/directory

@micahflee micahflee marked this pull request as ready for review July 23, 2024 17:56
@micahflee micahflee merged commit 0dd96e9 into main Jul 23, 2024
5 checks passed
@micahflee micahflee deleted the display-version branch July 23, 2024 19:49
@github-actions github-actions bot removed the deploy create dev deployment label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants