Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added poetry as dependency manager #285

Merged
merged 1 commit into from
Mar 19, 2024
Merged

added poetry as dependency manager #285

merged 1 commit into from
Mar 19, 2024

Conversation

brassy-endomorph
Copy link
Contributor

Fixes #199

  • added poetry to manage dependencies
    • only used top level deps, not all sub deps in requirements.txt
  • deleted requirements.txt
  • added .gitignore
  • updated install.sh
  • minor tweaks to other scripts in top-level directory

TODO?

From the ticket:

Update the README/documentation to reflect the use of Poetry.

We don't really have a HACKING.md or CONTRIBUTING.md or whatever, so it's unclear where docs should go

@glenn-sorrentino glenn-sorrentino merged commit 0d4791a into main Mar 19, 2024
4 checks passed
glenn-sorrentino
glenn-sorrentino reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@glenn-sorrentino glenn-sorrentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merged.

@glenn-sorrentino glenn-sorrentino mentioned this pull request Mar 19, 2024
Closed
@brassy-endomorph brassy-endomorph deleted the convert-to-poetry branch March 20, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glenn-sorrentino glenn-sorrentino glenn-sorrentino left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[App] - Integrate Poetry to manage the project's dependencies and virtual environment.
2 participants
@brassy-endomorph @glenn-sorrentino