Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile for fping #224

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Dockerfile for fping #224

merged 3 commits into from
Sep 7, 2023

Conversation

darless
Copy link
Contributor

@darless darless commented Jun 30, 2021

This adds a Dockerfile to the repository. The start of this is to build on the latest ubuntu (20.04).

I could see this being useful to test out new changes that require different versions of packages without affecting the host system. This is also useful if/when CI is modified to use Github Actions #223 as the dockerfile could automatically get pushed to the latest on a push to master.

Build:

docker build -t fping -f contrib/Dockerfile .

Run fping on a host that does not have fping currently

$ docker run -it fping 4.2.2.2 8.8.8.8 1.2.3.4
4.2.2.2 is alive
8.8.8.8 is alive
1.2.3.4 is unreachable

Run fping within container

docker run --entrypoint bash -it fping
root@8ca8ee184d27:/app# fping 4.2.2.2 1.2.3.4 -t 30
4.2.2.2 is alive
1.2.3.4 is unreachable

@schweikert
Copy link
Owner

Thank you, I am willing to merge this, but could you move it under "contrib"?

@darless
Copy link
Contributor Author

darless commented Dec 6, 2022

This has been done and updated original comment about how to build with Dockerfile in the contrib folder.

@darless
Copy link
Contributor Author

darless commented Aug 9, 2023

@schweikert what else is needed for PR to be merged?

@schweikert
Copy link
Owner

I still see a file named Dockerfile outside of the contrib directory.

@darless
Copy link
Contributor Author

darless commented Aug 31, 2023

You are correct, my apologies, should be corrected now. I left .dockerignore in the main directory, to allow building appropriately. If that's not accepted I can figure out how best to change the building of the docker container.

@schweikert
Copy link
Owner

Thanks!

@schweikert schweikert merged commit 8601d1b into schweikert:develop Sep 7, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants