correct various typos #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct various typos
swt2c
reviewed
Jun 19, 2018
docs/usage/usage_advanced_debug.rst
Outdated
| @@ -64,11 +64,11 @@ not be sent the message. Putting a try/except clause around every sendMessage is | |||
| typically not practical. | |||
|
|
|||
| Since exceptions are common during application development (bugs due to | |||
| invalid arguments, failed assertions, etc), Pypubsub provdes a hook to register | |||
| invalid arguments, failed assertions, etc...), Pypubsub provides a hook to register | |||
There was a problem hiding this comment.
I would argue there should just be a single period here after the etc. An ellipsis (...) is somewhat redundant with etc.
swt2c
reviewed
Jun 19, 2018
docs/usage/usage_advanced_debug.rst
Outdated
| a 'listener exception' handler: whenever a listener raises an exception, | ||
| Pypubsub then sends it to the handler, and continues with the send operation | ||
| until all listeners have received the message. The handler might print it to | ||
| a log file, output a message in a status bar, show an error box, etc. The | ||
| a log file, output a message in a status bar, show an error box, etc... The |
swt2c
reviewed
Jun 19, 2018
docs/usage/usage_advanced_debug.rst
Outdated
| this topic will receives all messages of every topic. By default, the listener | ||
| will not receive any data since pub.ALL_TOPICS is the parent of all root topics: | ||
| its MDS must be empty. | ||
|
|
||
| However, any listener that is a callable | ||
| with a "catch-all" \**kwargs parameter will be given all message data. Moreover, | ||
| Pypubsub sends the topic object automatically with the message data if it | ||
| Pypubsub sends the topic object automatically with the message data, if it |
There was a problem hiding this comment.
I don't think a comma is appropriate here.
|
Noted: I noticed the missing chars, corrected them, and thought that I'd scan the entire page for other things to correct in order to do a thorough job, and I think I got carried away trying to find stuff, sorry. |
|
Thanks I will check this once I get back from vacation next week |
|
Thanks @ReblochonMasque for fixes and @swt2c for reviewing, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several minor typos were corrected