Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

feature: Transparent Background support for removal of default white backgro… #437

Merged

Conversation

sumit0k
Copy link
Contributor

@sumit0k sumit0k commented May 18, 2018

…und when taking screenshot of element

Code example taken from puppeteer
https://github.com/GoogleChrome/puppeteer/blob/a310d57d847b008dba3b0772085840dde3343c64/lib/Page.js#L751

@codecov-io
Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #437 into master will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
+ Coverage   39.14%   39.19%   +0.04%     
==========================================
  Files           7        7              
  Lines         866      870       +4     
  Branches      121      123       +2     
==========================================
+ Hits          339      341       +2     
- Misses        527      529       +2
Impacted Files Coverage Δ
src/chrome/local-runtime.ts 27.27% <100%> (ø) ⬆️
src/util.ts 44.05% <60%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ec885...ed0ba41. Read the comment docs.

@sumit0k sumit0k changed the title feature: Omit Background support for removal of default white backgro… feature: Transparent Background support for removal of default white backgro… May 18, 2018
@adieuadieu adieuadieu merged commit fd9eaf3 into schickling:master Jul 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants