This repository has been archived by the owner on Nov 24, 2018. It is now read-only.
fix: load event not fired when page load very fast (fix #277, #297) #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
+ Coverage 38.03% 39.14% +1.11%
==========================================
Files 7 7
Lines 844 866 +22
Branches 116 121 +5
==========================================
+ Hits 321 339 +18
- Misses 523 527 +4
Continue to review full report at Codecov.
|
adieuadieu
approved these changes
Mar 9, 2018
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromeless is awesome! It's much easier to use compare to puppeteer / chromedriver.
But I found it might be stuck when the page is loaded very fast. According to examples in chrome-remote-interface's README, it might be caused by register load event callback after
Page.navigate, because the page could be already loaded if a page is loaded very fast. I tested in my case, the fast page load event is fired with this patch.Also, we cannot set a timeout for page load event, so I added an optional timeout parameter in
gotomethod.Here are some relevant issues:
#277
#297