EvaluatedMarkdownDocument interface #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Feb 3, 2024
olafurpg
approved these changes
Feb 15, 2024
|
Thanks for approvals, I will add some very basic tests tomorrow to this PR and then we can merge. |
- Add a method to java interfaces - Implement EvaluatedMarkdownDocument class - Update Mdoc implementation (currently in worksheets, but doesn't have to be)
6080b7b
to
a2f5857
Compare
|
@tgodzik I added a basic test (after 5+ months...) - still good to go? |
tgodzik
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to discuss with other maintainers.
Adding this method allows managing multiple mdoc instance via classloaders, and in general makes the Mdoc interface cover the thing most people would use mdoc for - markdown documents.
I've already confirmed that with this PR it's possible to use mdoc through a filtering classloader to render markdown documents, even with custom classpath.
cc @tgodzik @olafurpg @ckipp01