-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize field/subtype name comparison during macro expansion #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #478 +/- ##
==========================================
+ Coverage 89.85% 90.02% +0.17%
==========================================
Files 124 125 +1
Lines 4602 4663 +61
Branches 375 393 +18
==========================================
+ Hits 4135 4198 +63
+ Misses 467 465 -2 ☔ View full report in Codecov by Sentry. |
4 tasks
MateuszKubuszok
force-pushed
the
custom-name-comparator
branch
from
March 22, 2024 15:41
2665cf5
to
0d26434
Compare
…meComparison flags
…sableCustomSubtypeNameComparison flags
MateuszKubuszok
force-pushed
the
custom-name-comparator
branch
from
March 23, 2024 08:35
315f1b2
to
7e68c6b
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
object
by its type in the macro (based on https://github.com/MateuszKubuszok/MacroTypeclass)ProductTypes.areNamesEqual
withctx.config.flags.fieldNamesComparison
areFieldNamesEqual
delegating to the code aboveenumNamesEqual
withctx.config.flags.subtypeNamesComparison
areSubtypeNamesEqual
delegating to the code aboveenableFieldNamesMatching
+disableFieldNamesMatching
enableSubtypeNamesMatching
+dsableSubtypeNamesMatching
TransformedNamesComparison
TransformedNamesComparison