Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for project with no sources #10843

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

romanowski
Copy link
Contributor

@romanowski romanowski commented Dec 17, 2020

[test_sbt]

@romanowski romanowski changed the title Fix support for empty docs Fix support for projcet with no sources Dec 17, 2020
@tgodzik tgodzik changed the title Fix support for projcet with no sources Fix support for project with no sources Dec 17, 2020
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also bump sbt-dotty to 0.5.1 in https://github.com/lampepfl/dotty/blob/75365ead70a2ca3a39b0b351c0e80889c5e48ab3/project/Build.scala#L59, then I can do a release by pushing a tag.

@abgruszecki
Copy link
Contributor

Do I understand correctly that the doc task which is supposed to have no sources is test:doc, and doc is just a sanity check? If yes, this LGTM.

@romanowski romanowski force-pushed the scal3doc/fix-empty-projects branch 2 times, most recently from 32f1e42 to 402dbac Compare December 17, 2020 18:43
@romanowski
Copy link
Contributor Author

Do I understand correctly that the doc task which is supposed to have no sources is test:doc, and doc is just a sanity check? If yes, this LGTM.

The problem is that we need to adda fake scala file to workaround check in sbt that does not run doc if there is no scala file in sources. However when we add a fake file to sources where there is no provided then we just trigger doc just to fail on no tasty files provided (we filter out the fake file before).

Community build does not catch this problem since either projects has no publish set for docs or no sourcse in Test/doc and metals tries to publish empty test scope as a part of its CI

@romanowski
Copy link
Contributor Author

@smarter version is bumped

@romanowski romanowski mentioned this pull request Dec 17, 2020
1 task
bump sbtDotty version to 0.5.1
@abgruszecki
Copy link
Contributor

Ok, my bad, let me be more precise, I'm asking what exactly is testing that the issue will not reoccur. The newly-added test project has a single source in src and runs doc and test:doc. The fact that doc runs is just a sanity check, and the part that actually tests that doc doesn't fail with no sources is test:doc, is that correct?

@abgruszecki
Copy link
Contributor

Also, it seems that Dotty CI / test is stuck on "Checkout cleanup script", which is a bit strange.

@romanowski
Copy link
Contributor Author

The fact that doc runs is just a sanity check, and the part that actually tests that doc doesn't fail with no sources is test:doc, is that correct?

Yes. You try youself that before the fix test:doc would fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants