Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button for printing secretkey backup sheet #1146

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

ebma
Copy link
Member

@ebma ebma commented Sep 21, 2020

Adds a "Print" button to the secret-key export dialog. On 'initial-backup' the button is shown in the actions box next to the "Done" button and on default export it is shown next to the title of the inline dialog.

Closes #708.

on iOS:
Simulator Screen Shot - iPhone 11 Pro Max - 2020-09-21 at 16 56 06
Simulator Screen Shot - iPhone 11 Pro Max - 2020-09-21 at 16 55 59
on Android:
Screenshot_1600703637
in electron:
Screenshot 2020-09-21 at 11 31 34

@andywer
Copy link
Contributor

andywer commented Sep 22, 2020

Cool! Just one idea: What do you think about making the print landscape-oriented?

Secret Key Backup

(Not to be taken too seriously, I sketched this in 5mins 😉)

@ebma
Copy link
Member Author

ebma commented Sep 29, 2020

I re-designed the layout of the backup sheet. It now looks like this:

Screenshot 2020-09-29 at 17 23 32

on Android:

Screenshot 2020-09-29 at 16 52 14

on iOS:

Screenshot 2020-09-29 at 16 52 14

Any suggestions for improvement of the bottom text are appreciated.

@andywer
Copy link
Contributor

andywer commented Nov 4, 2020

@ebma How about this? I touch of color wouldn't hurt, but might look a little bit more balanced already.

Paper backup

@ebma
Copy link
Member Author

ebma commented Nov 4, 2020

Hmm I guess it does not look so 'harsh' this way. I have to have a look if I can rotate 'Public Key' and 'Secret Key' to point upwards, IIRC I used some css attribute which worked better when rotating downwards like I did. Of course I can also do some fiddling with css-transform and stuff but do you have any hard feelings on the rotation here?

@andywer
Copy link
Contributor

andywer commented Nov 5, 2020

No really hard feelings, just felt more natural to me that way.

Btw, wouldn't a simple transform: rotate(270deg) do the job? I could be wrong, though.

@ebma ebma force-pushed the feature/708-support-printing-key-backup-sheet branch from 6e4d929 to 8fd69cb Compare November 9, 2020 15:58
@ebma
Copy link
Member Author

ebma commented Nov 9, 2020

I added your suggested changes. It now looks like this
Screenshot 2020-11-09 at 16 49 17
which should be pretty close to what you imagined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support printing key backup sheet
2 participants